[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/3] scsi: Drop superfluous conditionals around g_fr
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 1/3] scsi: Drop superfluous conditionals around g_free() |
Date: |
Thu, 4 Dec 2014 14:12:43 +0100 |
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/scsi/scsi-generic.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c
index 6b9e4e1..e53470f 100644
--- a/hw/scsi/scsi-generic.c
+++ b/hw/scsi/scsi-generic.c
@@ -298,8 +298,7 @@ static int32_t scsi_send_command(SCSIRequest *req, uint8_t
*cmd)
#endif
if (r->req.cmd.xfer == 0) {
- if (r->buf != NULL)
- g_free(r->buf);
+ g_free(r->buf);
r->buflen = 0;
r->buf = NULL;
/* The request is used as the AIO opaque value, so add a ref. */
@@ -314,8 +313,7 @@ static int32_t scsi_send_command(SCSIRequest *req, uint8_t
*cmd)
}
if (r->buflen != r->req.cmd.xfer) {
- if (r->buf != NULL)
- g_free(r->buf);
+ g_free(r->buf);
r->buf = g_malloc(r->req.cmd.xfer);
r->buflen = r->req.cmd.xfer;
}
--
1.9.3
- [Qemu-devel] [PATCH 0/3] scsi: Trivial cleanups around g_malloc(), Markus Armbruster, 2014/12/04
- [Qemu-devel] [PATCH 2/3] scsi: Fuse g_malloc(); memset() into g_malloc0(), Markus Armbruster, 2014/12/04
- [Qemu-devel] [PATCH 3/3] scsi: Use g_new() & friends where that makes obvious sense, Markus Armbruster, 2014/12/04
- [Qemu-devel] [PATCH 1/3] scsi: Drop superfluous conditionals around g_free(),
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH 0/3] scsi: Trivial cleanups around g_malloc(), Eric Blake, 2014/12/04
- Re: [Qemu-devel] [PATCH 0/3] scsi: Trivial cleanups around g_malloc(), Fam Zheng, 2014/12/05
- Re: [Qemu-devel] [PATCH 0/3] scsi: Trivial cleanups around g_malloc(), Paolo Bonzini, 2014/12/05