[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [kernel PATCH] devicetree: document ARM bindings for QE
From: |
Arnd Bergmann |
Subject: |
Re: [Qemu-devel] [kernel PATCH] devicetree: document ARM bindings for QEMU's Firmware Config interface |
Date: |
Fri, 28 Nov 2014 13:59:43 +0100 |
User-agent: |
KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) |
On Friday 28 November 2014 13:26:44 Laszlo Ersek wrote:
> +Example:
> +
> +/ {
> + #size-cells = <0x2>;
> + #address-cells = <0x2>;
> +
> + address@hidden {
> + reg = <0x0 0x9020000 0x0 0x2 0x0 0x9020002 0x0 0x1>;
> + compatible = "fw-cfg,mmio";
> + };
> +};
>
"fw-cfg" is not a valid vendor string. Are you emulating an actual piece
of hardware here or is this something that comes from qemu?
How about using "qemu,fwcfg" as the compatible string, and documenting
"qemu" as an official vendor string in
Documentation/devicetree/bindings/vendor-prefixes.txt
We don't normally list contiguous registers separately. Maybe just round
up to one page and make the register property
reg = <0x0 0x9020000 0x0 0x1000>;
Finally, isn't there also an interrupt associated with this virtual device?
Arnd