[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/9] qga: fix false negative argument passing
From: |
arei.gonglei |
Subject: |
[Qemu-devel] [PATCH 3/9] qga: fix false negative argument passing |
Date: |
Sat, 15 Nov 2014 18:06:42 +0800 |
From: Gonglei <address@hidden>
Function send_response(s, &qdict->base) returns a negative number
when any faliures occured. But strerror()'s parameter cannot be
negative. Let's change the testing condition and pass '-ret' to
strerr().
Signed-off-by: Gonglei <address@hidden>
---
qga/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index 227f2bd..9939a2b 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -603,8 +603,8 @@ static void process_event(JSONMessageParser *parser, QList
*tokens)
error_free(err);
}
ret = send_response(s, QOBJECT(qdict));
- if (ret) {
- g_warning("error sending error response: %s", strerror(ret));
+ if (ret < 0) {
+ g_warning("error sending error response: %s", strerror(-ret));
}
}
--
1.7.12.4
- [Qemu-devel] [PATCH 0/9] Fix Coverity warning reports, arei.gonglei, 2014/11/15
- [Qemu-devel] [PATCH 7/9] qemu-char: fix MISSING_COMMA, arei.gonglei, 2014/11/15
- [Qemu-devel] [PATCH 3/9] qga: fix false negative argument passing,
arei.gonglei <=
- [Qemu-devel] [PATCH 6/9] acl: fix memory leak, arei.gonglei, 2014/11/15
- [Qemu-devel] [PATCH 5/9] nvme: remove superfluous check, arei.gonglei, 2014/11/15
- [Qemu-devel] [PATCH 4/9] loader: fix NEGATIVE_RETURNS, arei.gonglei, 2014/11/15
- [Qemu-devel] [PATCH 1/9] l2tpv3: fix fd leak, arei.gonglei, 2014/11/15