[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] sysbus: Correct SYSTEM_BUS(obj) defines
From: |
Gonglei |
Subject: |
Re: [Qemu-devel] [PATCH] sysbus: Correct SYSTEM_BUS(obj) defines |
Date: |
Tue, 11 Nov 2014 19:30:13 +0800 |
> Subject: Re: [Qemu-devel] [PATCH] sysbus: Correct SYSTEM_BUS(obj) defines
>
> <address@hidden> writes:
>
> > From: Gonglei <address@hidden>
> >
> > Signed-off-by: Gonglei <address@hidden>
> > ---
> > include/hw/sysbus.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h
> > index 6175bf9..d1f3f00 100644
> > --- a/include/hw/sysbus.h
> > +++ b/include/hw/sysbus.h
> > @@ -10,7 +10,7 @@
> > #define QDEV_MAX_PIO 32
> >
> > #define TYPE_SYSTEM_BUS "System"
> > -#define SYSTEM_BUS(obj) OBJECT_CHECK(IDEBus, (obj), TYPE_IDE_BUS)
> > +#define SYSTEM_BUS(obj) OBJECT_CHECK(BusState, (obj),
> TYPE_SYSTEM_BUS)
> >
> > typedef struct SysBusDevice SysBusDevice;
>
> Has never been used, so this is "only" an unexploded landmine. Hope
> it's the only one of this kind.
>
Yes, indeed.
> Reviewed-by: Markus Armbruster <address@hidden>
Thanks. :)
Best regards,
-Gonglei