[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 2/5] qemu-char: remove unnecessary in-parameter c
From: |
zhanghailiang |
Subject: |
[Qemu-devel] [PATCH v2 2/5] qemu-char: remove unnecessary in-parameter check for qemu_chr_parse_pipe |
Date: |
Mon, 3 Nov 2014 17:44:29 +0800 |
The check has been done in qemu_chr_parse_pipe, so we don't need to
check it again in qemu_chr_parse_pipe.
Signed-off-by: zhanghailiang <address@hidden>
---
qemu-char.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 04d747a..e1f0e28 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1084,11 +1084,6 @@ static CharDriverState
*qemu_chr_open_pipe(ChardevHostdev *opts)
char filename_out[CHR_MAX_FILENAME_SIZE];
const char *filename = opts->device;
- if (filename == NULL) {
- fprintf(stderr, "chardev: pipe: no filename given\n");
- return NULL;
- }
-
snprintf(filename_in, CHR_MAX_FILENAME_SIZE, "%s.in", filename);
snprintf(filename_out, CHR_MAX_FILENAME_SIZE, "%s.out", filename);
TFR(fd_in = qemu_open(filename_in, O_RDWR | O_BINARY));
--
1.7.12.4
- [Qemu-devel] [PATCH v2 0/5] Trivial patch about qemu-char, zhanghailiang, 2014/11/03
- [Qemu-devel] [PATCH v2 3/5] spice-qemu-char: fix parameter checks for qemu_chr_parse_* functions, zhanghailiang, 2014/11/03
- [Qemu-devel] [PATCH v2 4/5] qemu-char: convert some open functions to use Error API, zhanghailiang, 2014/11/03
- [Qemu-devel] [PATCH v2 2/5] qemu-char: remove unnecessary in-parameter check for qemu_chr_parse_pipe,
zhanghailiang <=
- [Qemu-devel] [PATCH v2 5/5] spice-qemu-char: convert qemu_chr_open_spice_vmc to use Error API, zhanghailiang, 2014/11/03
- [Qemu-devel] [PATCH v2 1/5] qemu-char: fix parameter check for some qemu_chr_parse_* functions, zhanghailiang, 2014/11/03
- Re: [Qemu-devel] [PATCH v2 0/5] Trivial patch about qemu-char, Michael Tokarev, 2014/11/03