[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/17] scsi: fixup lba calculation for 6 byte CD
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 04/17] scsi: fixup lba calculation for 6 byte CDBs |
|
Date: |
Wed, 29 Oct 2014 11:10:44 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 10/29/2014 10:52 AM, Hannes Reinecke wrote:
>>
> Because without this patch we end up with having a (basically random)
> value in cmd.lba, and we're ending up here:
>
> if (cmd.lba != -1) {
> trace_scsi_req_parsed_lba(d->id, d->lun, tag, buf[0], cmd.lba); }
Yeah, this is ugly but not fatal.
> and causing a buffer overflow when printing out the cdb.
Where exactly? This is the part I don't understand.
Paolo
[Qemu-devel] [PATCH 06/17] megasas: fixup MFI_DCMD_LD_LIST_QUERY, Hannes Reinecke, 2014/10/29
[Qemu-devel] [PATCH 16/17] megasas: Rework frame queueing algorithm, Hannes Reinecke, 2014/10/29
[Qemu-devel] [PATCH 09/17] megasas: add MegaRAID SAS 2108 emulation, Hannes Reinecke, 2014/10/29
[Qemu-devel] [PATCH 12/17] megasas: Clear unit attention on initial reset, Hannes Reinecke, 2014/10/29