[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH bugfix] snapshot: add bdrv_drain_all() to bdrv_s
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH bugfix] snapshot: add bdrv_drain_all() to bdrv_snapshot_delete() to avoid concurrency problem |
|
Date: |
Tue, 28 Oct 2014 15:18:52 +0000 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Oct 21, 2014 at 04:38:01PM +0800, Zhang Haoyu wrote:
> If there are still pending i/o while deleting snapshot,
> because deleting snapshot is done in non-coroutine context, and
> the pending i/o read/write (bdrv_co_do_rw) is done in coroutine context,
> so it's possible to cause concurrency problem between above two operations.
> Add bdrv_drain_all() to bdrv_snapshot_delete() to avoid this problem.
>
> Signed-off-by: Zhang Haoyu <address@hidden>
> ---
> block/snapshot.c | 4 ++++
> 1 file changed, 4 insertions(+)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
pgpN6jznSiegk.pgp
Description: PGP signature