[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 05/17] qcow2: Use sizeof(**refcount_table)
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v8 05/17] qcow2: Use sizeof(**refcount_table) |
Date: |
Wed, 22 Oct 2014 08:38:40 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 10/22/2014 06:09 AM, Max Reitz wrote:
> When implementing variable refcounts, we want to be able to easily find
> all the places in qemu which are tied to a certain refcount order.
> Replace sizeof(uint16_t) in the check code by sizeof(**refcount_table)
> so we can later find it more easily.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/qcow2-refcount.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v8 00/17] qcow2: Fix image repairing, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 02/17] qcow2: Calculate refcount block entry count, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 04/17] qcow2: Split qcow2_check_refcounts(), Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 01/17] block: Add qemu_{, try_}blockalign0(), Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 06/17] qcow2: Pull check_refblocks() up, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 03/17] qcow2: Fix leaks in dirty images, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 05/17] qcow2: Use sizeof(**refcount_table), Max Reitz, 2014/10/22
- Re: [Qemu-devel] [PATCH v8 05/17] qcow2: Use sizeof(**refcount_table),
Eric Blake <=
- [Qemu-devel] [PATCH v8 07/17] qcow2: Use int64_t for in-memory reftable size, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 08/17] qcow2: Split fail code in L1 and L2 checks, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 09/17] qcow2: Let inc_refcounts() return -errno, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 11/17] qcow2: Reuse refcount table in calculate_refcounts(), Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 10/17] qcow2: Let inc_refcounts() resize the reftable, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 12/17] qcow2: Fix refcount blocks beyond image end, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 14/17] qcow2: Rebuild refcount structure during check, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 13/17] qcow2: Do not perform potentially damaging repairs, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 15/17] qcow2: Clean up after refcount rebuild, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 17/17] iotests: Add test for potentially damaging repairs, Max Reitz, 2014/10/22