Re: [Qemu-devel] [PATCH] scripts/get_maintainer.pl: allow "odd fixes"

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> On 10/22/2014 09:47 AM, Markus Armbruster wrote:
>> Like this:
>> 
>>     $ scripts/get_maintainer.pl -f --no-git-fallback hw/ide/core.c 
>>     Kevin Wolf <address@hidden> (odd fixer:IDE)
>>     Stefan Hajnoczi <address@hidden> (odd fixer:IDE)
>> 
>> What's wrong with that?
>
> Michael's patch fixes the case where you do _not_ have --no-git-fallback:
>
>     $ scripts/get_maintainer.pl -f hw/ide/core.c 
>     Kevin Wolf <address@hidden> (odd fixer:IDE,commit_signer:6/27=22%)
>     Stefan Hajnoczi <address@hidden> (odd
> fixer:IDE,commit_signer:18/27=67%)
>     John Snow <address@hidden> (commit_signer:13/27=48%)
>     Paolo Bonzini <address@hidden> (commit_signer:11/27=41%)
>     Fam Zheng <address@hidden> (commit_signer:4/27=15%)
>
> With the patch:
>
>     $ scripts/get_maintainer.pl -f hw/ide/core.c 
>     Kevin Wolf <address@hidden> (odd fixer:IDE)
>     Stefan Hajnoczi <address@hidden> (odd fixer:IDE)
>
> which behaves the same as:
>
>     $ scripts/get_maintainer.pl -f block/qed.c
>     Kevin Wolf <address@hidden> (supporter:Block)
>     Stefan Hajnoczi <address@hidden> (supporter:Block)

Got it, thanks!

Shows how automatic --no-git-fallback has become for me...

>> > So this boils down to the fact that we use
>> > "odd fixer" incorrectly.
>> >
>> > I will apply this for now but maybe we should
>> > change MAINTAINERS switching all "Odd fixes" to
>> > "Maintained" and then revert this patch.
>> >
>> > Thoughts?
>> 
>> What exactly does this patch fix?

No objections to applying the patch.