[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] hmp: Remove "info pcmcia"
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 1/1] hmp: Remove "info pcmcia" |
Date: |
Wed, 01 Oct 2014 10:54:44 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Ping?
Markus Armbruster <address@hidden> writes:
> This command lists PCMCIA sockets and cards. Only a few ARM boards
> have sockets (akita, borzoi, connex, mainstone, spitz, terrier, tosa,
> verdex, z2), the only card is the DSCM-1xxxx Hitachi Microdrive (qdev
> "microdrive"), and it is only inserted during machine init, if ever.
> So this command doesn't really tell anybody anything new so far.
>
> Moreover, pcmcia_socket_unregister() has a use-after-free bug, flagged
> by Coverity. Has never been used, because there has never been code
> to eject a PCMCIA card.
>
> Not worth fixing & converting to QMP. Remove it.
>
> Signed-off-by: Markus Armbruster <address@hidden>
- Re: [Qemu-devel] [PATCH 1/1] hmp: Remove "info pcmcia",
Markus Armbruster <=