[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/6] add dumpdts ability to convert dtb to dts
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 0/6] add dumpdts ability to convert dtb to dts |
Date: |
Mon, 25 Aug 2014 13:22:34 +0100 |
On 25 August 2014 05:00, john.liuli <address@hidden> wrote:
> From: Li Liu <address@hidden>
>
> This patchset let qemu can convert dtb file to dts for two demands:
>
> Some archtectures may generate the dtb file dynamically through
> qemu device tree functions. So this let it's possiable to dump final
> dtb to dts and save it as a reference.
>
> For novices to debugging the issues caused by wrong dtb parameters.
> It will be easy to check the dts directly without copying the
> dtb which may be generated by 'dumpdtb' to the PC and dtc or fdtdump
> it.
>
> The outputed dts format is compatile with 'dtc -I dtb -O dts xxx.dtb'.
> There's a new parameter 'dumpdts' which is similar to 'dumpdtb'. so try
> it like '-machine dumpdts=/tmp/xxx.dts'.
Hi. Thanks for this patchset, but I'm afraid this doesn't
seem to me like something that should be in QEMU.
As you say, you can easily turn the dtb blob into a source file
with dtc. That gets you a definitely-correct disassembly of the
blob, and we don't need to maintain a possibly-buggy
reimplementation of the dtb disassembler in QEMU.
thanks
-- PMM
- [Qemu-devel] [PATCH 0/6] add dumpdts ability to convert dtb to dts, john.liuli, 2014/08/25
- [Qemu-devel] [PATCH 3/6] device_tree.c: Format a blob in memory as dts stream and dump to a file., john.liuli, 2014/08/25
- [Qemu-devel] [PATCH 1/6] device_tree.c: Introduce a function to check multiple strings for dts, john.liuli, 2014/08/25
- [Qemu-devel] [PATCH 2/6] device_tree.c: dump three kind data types of dts to a file desciptor, john.liuli, 2014/08/25
- [Qemu-devel] [PATCH 4/6] device_tree.c: add the main function to analyse the parameter 'dumpdts', john.liuli, 2014/08/25
- [Qemu-devel] [PATCH 6/6] arm: Allow dumping generated dtb to dts file, john.liuli, 2014/08/25
- [Qemu-devel] [PATCH 5/6] machine: add 'dumpdts' parameter to 'machine' optslist., john.liuli, 2014/08/25
- Re: [Qemu-devel] [PATCH 0/6] add dumpdts ability to convert dtb to dts,
Peter Maydell <=