[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH memory v1 1/1] memory: remove may_overlap proper
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH memory v1 1/1] memory: remove may_overlap property |
Date: |
Mon, 18 Aug 2014 08:33:53 +0100 |
On 18 August 2014 08:26, Peter Crosthwaite <address@hidden> wrote:
> On Mon, Aug 18, 2014 at 5:23 PM, Peter Maydell <address@hidden> wrote:
>> Oops, I mistakenly thought this check was happening at the
>> flattened-ranges point, but it's done when a subregion is
>> added to a container. Maybe you're right that we should be
>> able to allow overlaps if the priorities are different and not
>> otherwise, then. But I'd rather we actually did that rather than
>> just removing the check completely.
>>
>
> Right can we call it follow up though and get a merge on this one so
> we can start fresh? With your new hierarchy problem we are just
> compounding the reasons to get rid of this code.
That makes it harder to figure out whether we're still
detecting the same set of problems with the new
check, though.
-- PMM