[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 07/49] kvmapic: fixing loading vmstate
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 07/49] kvmapic: fixing loading vmstate |
Date: |
Tue, 29 Jul 2014 14:16:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
Il 29/07/2014 14:03, Pavel Dovgaluk ha scritto:
>> >
>> > This could be a subsection. sipi_vector is only used (needed) if
>> > wait_for_sipi != 0.
> Right, sipi_vector is used when wait_for_sipi != 0. But we can set
> sipi_vector to non-zero,
> save the snapshot, and then set wait_for_sipi. If that snapshot will be
> loaded, sipi_vector become incorrect.
> Isn't this scenario possible?
sipi_vector will not be used until CPU_INTERRUPT_SIPI is set, and then
sipi_vector will have been overwritten with a new value. The
architecture guarantees that.
Paolo
- [Qemu-devel] [RFC PATCH v2 01/49] acpi: accurate overflow check, (continued)
- [Qemu-devel] [RFC PATCH v2 01/49] acpi: accurate overflow check, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 02/49] integratorcp: adding vmstate for save/restore, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 04/49] fdc: adding vmstate for save/restore, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 03/49] pcspk: adding vmstate for save/restore, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 05/49] parallel: adding vmstate for save/restore, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 07/49] kvmapic: fixing loading vmstate, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 06/49] serial: fixing vmstate for save/restore, Pavel Dovgalyuk, 2014/07/17
[Qemu-devel] [RFC PATCH v2 08/49] hpet: fixing saving and loading process, Pavel Dovgalyuk, 2014/07/17
[Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmstate, Pavel Dovgalyuk, 2014/07/17