Re: [Qemu-devel] [PATCH 5/6] input: switch sparc32 kbd to new input api

[Gerd Hoffmann]

  Hi,

> > +    [Q_KEY_CODE_META_R]        = 122,
> > +    [Q_KEY_CODE_COMPOSE]       = 67,
> >  };
> This mapping does not look good on some details.
> 
>  COPY, FIND and CUT does not match the standard : 
>    [Q_KEY_CODE_COPY]          = 52 : Should be 0x33=51
> 
>    [Q_KEY_CODE_FIND]          = 97 : Should be 0x5F=95
> 
>    [Q_KEY_CODE_CUT]           = 99 : Should be 0x61=97

Hmm, can I type those somehow on a ps/2 kbd?
The sendkey monitor command doesn't work for them (in master).

Most likely those are not a regression from master.  Good to fix
nevertheless, I'll do it as incremental patch.  And it proves that this
cleanup is a good thing as it makes it *alot* easier to spot this kind
of bugs ;)

> > +    keycode = qcode_to_keycode[qcode];
> > +    if (evt->key->down) {
> > +        keycode |= 0x80;
> >      }
> 
> Instead : 
>     if (!evt->key->down) {
>         keycode |= 0x80;
>     }
> keycode +0x80 is for KeyUp events.

Good spotting, thanks.

> You can do some tests with "sparc-test-0.2.tar.gz" on qemu.org

Thanks.  Doesn't help much for the cut+copy keys though.

cheers,
  Gerd