Re: [Qemu-devel] [PATCH v9 1/4] qapi: [trivial] Break long command lines

[Eric Blake]

On 04/13/2014 01:07 PM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
>  Makefile       |   24 ++++++++++++++++++------
>  tests/Makefile |   20 ++++++++++++++++----
>  2 files changed, 34 insertions(+), 10 deletions(-)

Has this changed from v8?

https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg01914.html

If not (or if the extent of the change was limited to the cosmetic issue
that I mentioned back then), it is wise to modify the commit message to
include the 'Reviewed-by' tag that I stuck there, so that I can quickly
tell that it is unchanged from the version I previously reviewed.

>  $(patsubst %, check-%, $(check-qapi-schema-y)): check-%.json: 
> $(SRC_PATH)/%.json
> -     $(call quiet-command, PYTHONPATH=$(SRC_PATH)/scripts $(PYTHON) 
> $(SRC_PATH)/tests/qapi-schema/test-qapi.py <$^ >$*.test.out 2>$*.test.err; 
> echo $$? >$*.test.exit, "  TEST  $*.out")
> +     $(call quiet-command, PYTHONPATH=$(SRC_PATH)/scripts \
> +             $(PYTHON) $(SRC_PATH)/tests/qapi-schema/test-qapi.py \
> +             <$^ \
> +             >$*.test.out \
> +             2>$*.test.err; \
> +             echo $$? >$*.test.exit, \

Nope, you didn't make the cosmetic change.  At any rate, my review still
stands.

http://wiki.qemu.org/Contribute/SubmitAPatch mentions why it is
important to use Reviewed-by tags correctly to help speed up reviews of
subsequent revisions.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature