qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V7 10/11] qapi script: do not add "_" for every

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH V7 10/11] qapi script: do not add "_" for every capitalized char in enum
Date: Thu, 20 Feb 2014 10:53:19 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 
On 02/20/2014 09:54 AM, Markus Armbruster wrote:
>> +        # When c is upper and no "_" appears before, do more checks
>> +        if c.isupper() and (i > 0) and c_fun_str[i - 1] != "_":
> 
> c_fun_str[i - 1]... what if i == 0?

How? We already had '(i > 0) and' prior to the use of i-1.


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to
[Prev in Thread] Current Thread [Next in Thread]