Re: [Qemu-devel] [PATCH 01/16] qemu-char: Allocate CharDriverState in qemu_chr_new_from_opts

[Andreas Färber]

Am 12.11.2013 17:33, schrieb Corey Minyard:
> This allocates the CharDriverState structure and passes it in to the
> open routine.  This allows a coming option to automatically attempt to
> reconnect a chardev if the connection fails.  The chardev has to be
> kept around so a reconnect can be done on it.
> 
> Signed-off-by: Corey Minyard <address@hidden>
[...]
> diff --git a/include/ui/qemu-spice.h b/include/ui/qemu-spice.h
> index 86c75c7..eadb9c9 100644
> --- a/include/ui/qemu-spice.h
> +++ b/include/ui/qemu-spice.h
> @@ -46,9 +46,11 @@ int qemu_spice_migrate_info(const char *hostname, int 
> port, int tls_port,
>  void do_info_spice_print(Monitor *mon, const QObject *data);
>  void do_info_spice(Monitor *mon, QObject **ret_data);
>  
> -CharDriverState *qemu_chr_open_spice_vmc(const char *type);
> +CharDriverState *qemu_chr_open_spice_vmc(CharDriverState *chr,
> +                                         const char *type);
>  #if SPICE_SERVER_VERSION >= 0x000c02
> -CharDriverState *qemu_chr_open_spice_port(const char *name);
> +CharDriverState *qemu_chr_open_spice_port(CharDriverSTate *chr,

This needs to be CharDriverState.

> +                                          const char *name);
>  void qemu_spice_register_ports(void);
>  #else
>  static inline CharDriverState *qemu_chr_open_spice_port(const char *name)
[snip]

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg