[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Seabios] [PATCH v2] seabios: restore piix pm config re
From: |
Kevin O'Connor |
Subject: |
Re: [Qemu-devel] [Seabios] [PATCH v2] seabios: restore piix pm config registers after resume |
Date: |
Wed, 15 Jan 2014 11:04:55 -0500 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jan 15, 2014 at 02:24:40PM +0200, Marcel Apfelbaum wrote:
> On Wed, 2014-01-15 at 14:20 +0200, Marcel Apfelbaum wrote:
> > On resume, the OS queries the power management event that
> > caused it. In order to complete this task, it executes some
> > reads to the piix pm io space. This all happens before the
> > OS has a chance to restore the PCI config space for devices,
> > so it is bios's responsibility to make sure the pm IO space
> > is configured correctly. (During suspend, the piix pm
> > configuration space is lost).
> >
> > Note: For 'ordinary' pci devices the config space is
> > saved by the OS on sleep and restored on resume.
> >
> > Signed-off-by: Marcel Apfelbaum <address@hidden>
>
> Ooops! I put a [Qemu-devel] prefix, it is going to be a problem?
I fixed it up. The patch also had two header files declaring
pci_resume() - I fixed that up as well. It's been committed.
Thanks.
-Kevin