Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

[Paolo Bonzini]

Il 02/01/2014 11:51, Peter Crosthwaite ha scritto:
>> > No, please use "realize" and avoid init.  This way you can use an Error*
>> > to report the error.
>> >
>> > Also, the actual load_image_targphys call probably should be done in a
>> > reset handler, not at realize time.
>> >
> Ok I think that settles it. The actual blobbing needs to happen at
> reset time. Perhaps the correct approach is to do as much as possible
> (file-path / address sanitsation etc) at realize time, then only the
> actual blob load happens at reset. Going on what Paolo said, I think
> for this device ::init is actually a nop.

Yeah, also because init is in fact a legacy interface to realize.

Paolo