[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/10] target-arm: Give the FPSCR rounding modes
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 10/10] target-arm: Give the FPSCR rounding modes names |
|
Date: |
Mon, 30 Dec 2013 07:29:20 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 12/28/2013 01:49 PM, Peter Maydell wrote:
> From: Alexander Graf <address@hidden>
>
> When setting rounding modes we currently just hardcode the numeric values
> for rounding modes in a big switch statement.
>
> With AArch64 support coming, we will need to refer to these rounding modes
> at different places throughout the code though, so let's better give them
> names so we don't get confused by accident.
>
> Signed-off-by: Alexander Graf <address@hidden>
> [WN: Commit message tweak, use names from ARM ARM.]
> Signed-off-by: Will Newton <address@hidden>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> target-arm/cpu.h | 9 +++++++++
> target-arm/helper.c | 8 ++++----
> 2 files changed, 13 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~