[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/17] hw/arm/highbank: Simplify code (memory region
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 01/17] hw/arm/highbank: Simplify code (memory region in device state) |
Date: |
Sat, 28 Dec 2013 02:07:14 +0400 |
From: Stefan Weil <address@hidden>
The memory region can be included by value instead of by reference in the
device state.
Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/arm/highbank.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c
index c75b425..d76a1d1 100644
--- a/hw/arm/highbank.c
+++ b/hw/arm/highbank.c
@@ -126,7 +126,7 @@ typedef struct {
SysBusDevice parent_obj;
/*< public >*/
- MemoryRegion *iomem;
+ MemoryRegion iomem;
uint32_t regs[NUM_REGS];
} HighbankRegsState;
@@ -155,10 +155,9 @@ static int highbank_regs_init(SysBusDevice *dev)
{
HighbankRegsState *s = HIGHBANK_REGISTERS(dev);
- s->iomem = g_new(MemoryRegion, 1);
- memory_region_init_io(s->iomem, OBJECT(s), &hb_mem_ops, s->regs,
+ memory_region_init_io(&s->iomem, OBJECT(s), &hb_mem_ops, s->regs,
"highbank_regs", 0x1000);
- sysbus_init_mmio(dev, s->iomem);
+ sysbus_init_mmio(dev, &s->iomem);
return 0;
}
--
1.7.10.4
- [Qemu-devel] [PULL 00/17] trivial patches for 2013-12-27, Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 01/17] hw/arm/highbank: Simplify code (memory region in device state),
Michael Tokarev <=
- [Qemu-devel] [PULL 05/17] exynos4210: Use macro ARRAY_SIZE where possible, Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 03/17] misc: Use macro ARRAY_SIZE where possible, Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 02/17] openrisc: Fix spelling in comment (transaltion -> translation), Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 07/17] x86: only allow real mode to access 32bit without LMA, Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 08/17] vl: make boot_strict variable static (not used outside vl.c), Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 15/17] pxa27x: Add 'const' attribute to keyboard maps, Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 06/17] linux-user: Use macro TARGET_NSIG_WORDS where possible, Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 11/17] configure: Rewrite code for help message, Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 09/17] fix -boot strict regressed in commit 6ef4716, Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 12/17] configure: Python tests must be done before help message, Michael Tokarev, 2013/12/27