[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-ppc: fix VSX extension TCG code
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH] target-ppc: fix VSX extension TCG code |
Date: |
Sun, 22 Dec 2013 14:16:42 +0100 |
> Am 22.12.2013 um 12:26 schrieb Aurelien Jarno <address@hidden>:
>
> The VSX TCG code is using _i64 types mixed wiht _tl types. While this
> is correct for 64-bit targets, this breaks the compilation with 32-bit
> targets and --enable-debug-tcg.
>
> This patch fixes that by always using the correct type. Note that we can
> probably do better for the load/stores using the new load/store TCG
> instructions, but that would need changes to other places of the code,
> while this patch intents to be a bug fix patch only.
>
> Cc: Tom Musta <address@hidden>
> Cc: Alexander Graf <address@hidden>
> Signed-off-by: Aurelien Jarno <address@hidden>
I've sent a similar patch last week. Would you mind to review that one and
maybe ack it?
Thanks a lot!
Alex