Re: [Qemu-devel] [PATCH V7 2/6] qcow2: add error message in qcow2_write_snapshots()

[Stefan Hajnoczi]

On Thu, Dec 05, 2013 at 08:02:48PM +0800, Wenchao Xia wrote:
> @@ -227,24 +236,40 @@ static int qcow2_write_snapshots(BlockDriverState *bs)
>  
>          ret = bdrv_pwrite(bs->file, offset, &h, sizeof(h));
>          if (ret < 0) {
> +            error_setg_errno(errp, -ret,
> +                             "Failed in write of snapshot header at %"
> +                             PRIi64 " with size %d",
> +                             offset, (int)sizeof(h));

The casts in this patch are not necessary:
size_t == %zu
ssize_t == %zd

(Very minor point but in case you respin)