Re: [Qemu-devel] [PATCH 09/38] memory: set single dirty flags when possible

[Orit Wasserman]

On 12/17/2013 05:25 PM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>   exec.c                         | 7 ++++---
>   include/exec/memory-internal.h | 4 +++-
>   2 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index a1fc280..6981f73 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1911,7 +1911,8 @@ static void invalidate_and_set_dirty(hwaddr addr,
>           /* invalidate code */
>           tb_invalidate_phys_page_range(addr, addr + length, 0);
>           /* set dirty bit */
> -        cpu_physical_memory_set_dirty_flags(addr, (0xff & ~CODE_DIRTY_FLAG));
> +        cpu_physical_memory_set_dirty_flag(addr, VGA_DIRTY_FLAG);
> +        cpu_physical_memory_set_dirty_flag(addr, MIGRATION_DIRTY_FLAG);
>       }
>       xen_modified_memory(addr, length);
>   }
> @@ -2493,8 +2494,8 @@ void stl_phys_notdirty(hwaddr addr, uint32_t val)
>                   /* invalidate code */
>                   tb_invalidate_phys_page_range(addr1, addr1 + 4, 0);
>                   /* set dirty bit */
> -                cpu_physical_memory_set_dirty_flags(
> -                    addr1, (0xff & ~CODE_DIRTY_FLAG));
> +                cpu_physical_memory_set_dirty_flag(addr1, 
> MIGRATION_DIRTY_FLAG);
> +                cpu_physical_memory_set_dirty_flag(addr1, VGA_DIRTY_FLAG);
>               }
>           }
>       }
> diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
> index 53cfe83..9f4ad69 100644
> --- a/include/exec/memory-internal.h
> +++ b/include/exec/memory-internal.h
> @@ -89,7 +89,9 @@ static inline void 
> cpu_physical_memory_set_dirty_flag(ram_addr_t addr,
>
>   static inline void cpu_physical_memory_set_dirty(ram_addr_t addr)
>   {
> -    cpu_physical_memory_set_dirty_flags(addr, 0xff);
> +    cpu_physical_memory_set_dirty_flag(addr, MIGRATION_DIRTY_FLAG);
> +    cpu_physical_memory_set_dirty_flag(addr, VGA_DIRTY_FLAG);
> +    cpu_physical_memory_set_dirty_flag(addr, CODE_DIRTY_FLAG);
>   }
>
>   static inline int cpu_physical_memory_clear_dirty_flags(ram_addr_t addr,

Reviewed-by: Orit Wasserman <address@hidden>