[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 8/8] s390x/ioinst: CHSC has to set a condition code
From: |
Jens Freimann |
Subject: |
[Qemu-devel] [PATCH 8/8] s390x/ioinst: CHSC has to set a condition code |
Date: |
Tue, 17 Dec 2013 14:22:10 +0100 |
From: Thomas Huth <address@hidden>
I missed to set the CC in the CHSC instruction when I refactored
the CC setting in the IO instructions with the following commit:
5d9bf1c07c1369ab3506fc82cc65a10f4415d867
s390/ioinst: Moved the CC setting to the IO instruction handlers
This patch now restores the correct behaviour of CHSC by setting the
condition code 0 at the end of the instruction.
Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Jens Freimann <address@hidden>
---
target-s390x/ioinst.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target-s390x/ioinst.c b/target-s390x/ioinst.c
index 8d6363d..b8a6486 100644
--- a/target-s390x/ioinst.c
+++ b/target-s390x/ioinst.c
@@ -622,6 +622,7 @@ void ioinst_handle_chsc(S390CPU *cpu, uint32_t ipb)
break;
}
+ setcc(cpu, 0); /* Command execution complete */
out:
s390_cpu_physical_memory_unmap(env, req, map_size, 1);
}
--
1.8.3.4
- [Qemu-devel] [PATCH 0/8] s390 sigp, chsc and diag bugfixes/cleanups, Jens Freimann, 2013/12/17
- [Qemu-devel] [PATCH 1/8] s390x/kvm: Fix diagnose handling., Jens Freimann, 2013/12/17
- [Qemu-devel] [PATCH 4/8] s390x/kvm: Fix coding style in handle_sigp(), Jens Freimann, 2013/12/17
- [Qemu-devel] [PATCH 2/8] s390x/kvm: Removed duplicated SIGP defines, Jens Freimann, 2013/12/17
- [Qemu-devel] [PATCH 3/8] s390x/kvm: Removed s390_store_status stub, Jens Freimann, 2013/12/17
- [Qemu-devel] [PATCH 6/8] s390x/kvm: Simplified the calculation of the SIGP order code, Jens Freimann, 2013/12/17
- [Qemu-devel] [PATCH 8/8] s390x/ioinst: CHSC has to set a condition code,
Jens Freimann <=
- [Qemu-devel] [PATCH 5/8] s390x/kvm: Implemented SIGP START, Jens Freimann, 2013/12/17
- [Qemu-devel] [PATCH 7/8] s390x/kvm: Fixed condition code for unknown SIGP orders, Jens Freimann, 2013/12/17
- Re: [Qemu-devel] [PATCH 0/8] s390 sigp, chsc and diag bugfixes/cleanups, Alexander Graf, 2013/12/18