[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 2/3] qapi script: add support of event
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH RFC 2/3] qapi script: add support of event |
Date: |
Mon, 16 Dec 2013 10:04:28 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Wenchao Xia <address@hidden> writes:
> δΊ 2013/12/13 21:43, Kevin Wolf ει:
>> Am 13.12.2013 um 14:31 hat Eric Blake geschrieben:
>>> On 11/12/2013 06:44 PM, Wenchao Xia wrote:
>>>> +++ b/scripts/qapi-event.py
>>>> @@ -0,0 +1,355 @@
>>>> +#
>>>> +# QAPI event generator
>>>> +#
>>>> +# Copyright IBM, Corp. 2013
>>>> +#
>>>> +# Authors:
>>>> +# Wenchao Xia <address@hidden>
>>>> +#
>>>> +# This work is licensed under the terms of the GNU GPLv2.
>>>
>>> Can you please use GPLv2+ (that is, add the "or later" clause)? We
>>> already have GPLv2-only code, but I don't want to increase the size of
>>> that unfortunate license choice.
>>
>> In fact, it's even worse:
>>
>> +# This work is licensed under the terms of the GNU GPLv2.
>> +# See the COPYING.LIB file in the top-level directory.
>>
>> These two lines contradict each other, COPYING.LIB contains the
>> LGPL 2.1. The same bad license header is in the other QAPI generator
>> scripts, so it's only copy&paste here.
>>
>> This doesn't make things easier, because if things are copied, the
>> license of the source must be respected. And it seems rather dubious to
>> me what this license actually is. If it's GPLv2-only, we can't just
>> change it in the new copy.
>>
>> Kevin
>>
> ah..I am bad in license problem, will use the doc as LGPL from other
> file.
Please use GPLv2+ unless you have a specific reason for another license.