[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 7/7] commit: Remove unused check
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v7 7/7] commit: Remove unused check |
Date: |
Mon, 16 Dec 2013 14:45:33 +0800 |
We support top == active for commit now, remove the check and add an
assertion here.
Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
---
block/commit.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/block/commit.c b/block/commit.c
index d4090cb..acec4ac 100644
--- a/block/commit.c
+++ b/block/commit.c
@@ -198,13 +198,7 @@ void commit_start(BlockDriverState *bs, BlockDriverState
*base,
return;
}
- /* Once we support top == active layer, remove this check */
- if (top == bs) {
- error_setg(errp,
- "Top image as the active layer is currently unsupported");
- return;
- }
-
+ assert(top != bs);
if (top == base) {
error_setg(errp, "Invalid files for merge: top and base are the same");
return;
--
1.8.5.1
- [Qemu-devel] [PATCH v7 0/7] block: allow commit active as top, Fam Zheng, 2013/12/16
- [Qemu-devel] [PATCH v7 1/7] blkdebug: Use QLIST_FOREACH_SAFE to resume IO, Fam Zheng, 2013/12/16
- [Qemu-devel] [PATCH v7 2/7] mirror: Don't close target, Fam Zheng, 2013/12/16
- [Qemu-devel] [PATCH v7 3/7] mirror: Move base to MirrorBlockJob, Fam Zheng, 2013/12/16
- [Qemu-devel] [PATCH v7 5/7] commit: Support commit active layer, Fam Zheng, 2013/12/16
- [Qemu-devel] [PATCH v7 6/7] qemu-iotests: Update test cases for commit active, Fam Zheng, 2013/12/16
- [Qemu-devel] [PATCH v7 4/7] block: Add commit_active_start(), Fam Zheng, 2013/12/16
- [Qemu-devel] [PATCH v7 7/7] commit: Remove unused check,
Fam Zheng <=
- Re: [Qemu-devel] [PATCH v7 0/7] block: allow commit active as top, Stefan Hajnoczi, 2013/12/20