|
| From: | Richard Henderson |
| Subject: | Re: [Qemu-devel] [PATCH 02/18] target-ppc: Add ISA2.06 bpermd Instruction |
| Date: | Mon, 09 Dec 2013 16:01:18 -0800 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 12/09/2013 07:46 AM, Tom Musta wrote:
> + for (i = 0; i < 8; i++) {
> + int index = (rs & (0xFFul) << (i*8)) >> (i*8);
This is a silly expression. Better as
int index = (rs >> (i * 8)) & 0xff;
> + ra |= (1<<i);
Unnecessary parens, and missing spaces around the operator.
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |