Re: [Qemu-devel] [PATCH] char: restore read callback on a reattached (hotplug) chardev

[Amit Shah]

Hi,

On (Mon) 25 Nov 2013 [10:07:40], Gal Hammer wrote:
> Fix a bug that was introduced in commit 386a5a1e. A removal of a device
> set the chr handlers to NULL. However when the device is plugged back,
> its read callback is not restored so data can't be transfter from the
> host to the guest via the virtio-serial port.

Yes, good catch.

That commit removes the callback for all backend types, but this
commit only takes care of tcp.  Can you check the others too?  There
are a couple of backends which even remove their callback in the
update_read_handler() function, which may result in a double-free.

Can you look at that too?

Thanks,

                Amit