Re: [Qemu-devel] [PATCH arm-devs v4 3/4] hw/timer: Introduce ARM A9 Global Timer.

[Markus Armbruster]

Peter Maydell <address@hidden> writes:

> On 2 December 2013 12:28, Andreas Färber <address@hidden> wrote:
>> Am 02.12.2013 08:36, schrieb Peter Crosthwaite:
>>> The ARM A9 MPCore has a timer that is global to all CPUs in the mpcore.
>>> The timer is shared but each CPU has a private independent comparator
>>> and interrupt.
>>> +    dc->no_user = 1;
>>
>> There is a series from Markus waiting on my review that renames and
>> investigates all uses of this field. Please explain why you are using it
>> (in form of a comment) or drop it. There's only a numeric property
>> above, so likely the latter.
>
> It's a sysbus device so it's never going to be usable via device-add.

Not sure about "never", but it doesn't matter now.

> I think Markus' patchset puts that check in the sysbus base class
> though, which would make dropping the no_user here correct.

Yes.