Re: [Qemu-devel] [PATCH for-1.7?] the calculation of bytes_xfer in qemu_put_buffer() is wrong

[Stefan Weil]

Am 19.11.2013 09:19, schrieb Paolo Bonzini:
> Il 19/11/2013 06:53, Wangting (Kathy) ha scritto:
>> In qemu_put_buffer(), bytes_xfer += size is wrong,it will be more than
>> expected,and should be bytes_xfer += l.
>>
>> Signed-off-by: zhangmin <address@hidden>
>> ---
>> savevm.c |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/savevm.c b/savevm.c
>> index 2f631d4..3f912dd 100644
>> --- a/savevm.c
>> +++ b/savevm.c
>> @@ -794,7 +794,7 @@ void qemu_put_buffer(QEMUFile *f, const uint8_t *buf, 
>> int size)
>>          if (l > size)
>>              l = size;
>>          memcpy(f->buf + f->buf_index, buf, l);
>> -        f->bytes_xfer += size;
>> +        f->bytes_xfer += l;
>>          if (f->ops->writev_buffer) {
>>              add_to_iovec(f, f->buf + f->buf_index, l);
>>          }
>> -- 
>> 1.7.3.1.msysgit.0
> Reviewed-by: Paolo Bonzini <address@hidden>


Should this patch be included in QEMU 1.7? It's obviously a bug fix, so
I assume yes.