[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_not
From: |
Vlad Yasevich |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify() |
Date: |
Mon, 18 Nov 2013 08:54:20 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 11/18/2013 08:47 AM, Amos Kong wrote:
> object_get_canonical_path() returns a gchar*, it should be freeed by the
> caller.
>
> Signed-off-by: Amos Kong <address@hidden>
Reviewed-by: Vlad Yasevich <address@hidden>
-vlad
> ---
> hw/net/virtio-net.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index 613f144..2b2fb57 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -198,15 +198,14 @@ static void rxfilter_notify(NetClientState *nc)
> {
> QObject *event_data;
> VirtIONet *n = qemu_get_nic_opaque(nc);
> + gchar *path = object_get_canonical_path(OBJECT(n->qdev));
>
> if (nc->rxfilter_notify_enabled) {
> if (n->netclient_name) {
> event_data = qobject_from_jsonf("{ 'name': %s, 'path': %s }",
> - n->netclient_name,
> -
> object_get_canonical_path(OBJECT(n->qdev)));
> + n->netclient_name, path);
> } else {
> - event_data = qobject_from_jsonf("{ 'path': %s }",
> -
> object_get_canonical_path(OBJECT(n->qdev)));
> + event_data = qobject_from_jsonf("{ 'path': %s }", path);
> }
> monitor_protocol_event(QEVENT_NIC_RX_FILTER_CHANGED, event_data);
> qobject_decref(event_data);
> @@ -214,6 +213,7 @@ static void rxfilter_notify(NetClientState *nc)
> /* disable event notification to avoid events flooding */
> nc->rxfilter_notify_enabled = 0;
> }
> + g_free(path);
> }
>
> static char *mac_strdup_printf(const uint8_t *mac)
>