[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/2] milkymist-uart: use qemu_chr_fe_write_all() ins
From: |
Antony Pavlov |
Subject: |
[Qemu-devel] [PATCH 1/2] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write() |
Date: |
Sat, 31 Aug 2013 09:33:56 +0400 |
Here is a quote from the qemu-devel maillist:
<quote author="Peter Crosthwaite"
url="http://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg04748.html">
qemu_chr_fe_write() is capable of returning 0
to indicate EAGAIN (and friends) and you don't
handle this.
</quote>
Just change it to qemu_chr_fe_write_all() to fix.
Signed-off-by: Antony Pavlov <address@hidden>
CC: Peter Crosthwaite <address@hidden>
CC: Michael Walle <address@hidden>
---
hw/char/milkymist-uart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/char/milkymist-uart.c b/hw/char/milkymist-uart.c
index 2e4b5c5..6e4bc20 100644
--- a/hw/char/milkymist-uart.c
+++ b/hw/char/milkymist-uart.c
@@ -124,7 +124,7 @@ static void uart_write(void *opaque, hwaddr addr, uint64_t
value,
switch (addr) {
case R_RXTX:
if (s->chr) {
- qemu_chr_fe_write(s->chr, &ch, 1);
+ qemu_chr_fe_write_all(s->chr, &ch, 1);
}
s->regs[R_STAT] |= STAT_TX_EVT;
break;
--
1.8.4.rc3