Re: [Qemu-devel] [PATCH v3 3/3] hpet: entitle more irq pins for hpet

[Paolo Bonzini]

Il 30/08/2013 14:31, Andreas Färber ha scritto:
>> >  static Property hpet_device_properties[] = {
>> >      DEFINE_PROP_UINT8("timers", HPETState, num_timers, HPET_MIN_TIMERS),
>> >      DEFINE_PROP_BIT("msi", HPETState, flags, HPET_MSI_SUPPORT, false),
>> > +    DEFINE_PROP_UINT32("intcap", HPETState, intcap, 
>> > HPET_TN_INT_CAP_DEFAULT),
> What is "intcap"? It sounds like capabilities? In that case
> DEFINE_PROP_BIT() might be a more appropriate way to model individually
> tweakable properties? Either way, the property name could probably use
> some love for clarity - there is no explanation for users.

Unless you want 24 properties (one per pin), an UINT32 is fine. :)

Paolo