[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 06/16] monitor: avoid use of global *cur_mon in readl
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PULL 06/16] monitor: avoid use of global *cur_mon in readline_completion() |
Date: |
Fri, 30 Aug 2013 08:22:27 -0400 |
From: Wenchao Xia <address@hidden>
Now all completion functions do not use *cur_mon any more, instead
they use rs->mon. In short, structure ReadLineState decide where
the complete action would be taken now.
Tested with the case that qemu have two telnet monitors, auto
completion function works normal.
Signed-off-by: Wenchao Xia <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>
---
readline.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/readline.c b/readline.c
index c91b324..abf27dd 100644
--- a/readline.c
+++ b/readline.c
@@ -276,7 +276,6 @@ void readline_set_completion_index(ReadLineState *rs, int
index)
static void readline_completion(ReadLineState *rs)
{
- Monitor *mon = cur_mon;
int len, i, j, max_width, nb_cols, max_prefix;
char *cmdline;
@@ -300,7 +299,7 @@ static void readline_completion(ReadLineState *rs)
if (len > 0 && rs->completions[0][len - 1] != '/')
readline_insert_char(rs, ' ');
} else {
- monitor_printf(mon, "\n");
+ monitor_printf(rs->mon, "\n");
max_width = 0;
max_prefix = 0;
for(i = 0; i < rs->nb_completions; i++) {
--
1.8.1.4
- [Qemu-devel] [PULL 00/16] QMP queue, Luiz Capitulino, 2013/08/30
- [Qemu-devel] [PULL 01/16] monitor: Add missing attributes to local function, Luiz Capitulino, 2013/08/30
- [Qemu-devel] [PULL 02/16] monitor: avoid use of global *cur_mon in cmd_completion(), Luiz Capitulino, 2013/08/30
- [Qemu-devel] [PULL 04/16] monitor: avoid use of global *cur_mon in block_completion_it(), Luiz Capitulino, 2013/08/30
- [Qemu-devel] [PULL 03/16] monitor: avoid use of global *cur_mon in file_completion(), Luiz Capitulino, 2013/08/30
- [Qemu-devel] [PULL 05/16] monitor: avoid use of global *cur_mon in monitor_find_completion(), Luiz Capitulino, 2013/08/30
- [Qemu-devel] [PULL 06/16] monitor: avoid use of global *cur_mon in readline_completion(),
Luiz Capitulino <=
- [Qemu-devel] [PULL 07/16] monitor: call sortcmdlist() only one time, Luiz Capitulino, 2013/08/30
- [Qemu-devel] [PULL 08/16] monitor: split off monitor_data_init(), Luiz Capitulino, 2013/08/30
- [Qemu-devel] [PULL 09/16] monitor: avoid direct use of global variable *mon_cmds, Luiz Capitulino, 2013/08/30
- [Qemu-devel] [PULL 10/16] monitor: code move for parse_cmdline(), Luiz Capitulino, 2013/08/30
- [Qemu-devel] [PULL 11/16] monitor: refine parse_cmdline(), Luiz Capitulino, 2013/08/30
- [Qemu-devel] [PULL 12/16] monitor: support sub command in help, Luiz Capitulino, 2013/08/30
- [Qemu-devel] [PULL 13/16] monitor: refine monitor_find_completion(), Luiz Capitulino, 2013/08/30
- [Qemu-devel] [PULL 14/16] monitor: support sub command in auto completion, Luiz Capitulino, 2013/08/30
- [Qemu-devel] [PULL 15/16] monitor: allow "help" show message for single command in sub group, Luiz Capitulino, 2013/08/30
- [Qemu-devel] [PULL 16/16] monitor: improve auto complete of "help" for single command in sub group, Luiz Capitulino, 2013/08/30