Re: [Qemu-devel] [PATCH v3 0/8] Add metadata overlap checks

[Kevin Wolf]

Am 30.08.2013 um 09:46 hat Max Reitz geschrieben:
> If a qcow2 image file becomes corrupted, any write may inadvertently
> overwrite important metadata structures such as the L1 table. This
> series adds functionality for detecting, preventing and (to some extent)
> repairing such collisions.
> 
> v3:
>  - split PATCH 4/5 into four distinct patches (4/8, 5/8, 6/8 and 7/8,
>    respectively)
>  - directly generate a JSON message when marking the image corrupt
>  - other (minor) fixes according to Kevin's comments
> 
> v2:
>  - Generally implemented Kevin's comments, especially:
>     - new QMP event QEVENT_BLOCK_IMAGE_CORRUPTED
>     - removed BDRV_O_REPAIR in favor of BDRV_O_CHECK | BDRV_O_RDWR
>     - always check full clusters for overlaps
>  - removed qcow2_check_allocations in favor of some
>    qcow2_check_refcounts extensions that will hopefully include all
>    that functionality

Commented on patch 4, the others are:

Reviewed-by: Kevin Wolf <address@hidden>