Re: [Qemu-devel] [PATCH v4 08/21] block: expect errors from bdrv_co_is_allocated

[Paolo Bonzini]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Il 29/08/2013 23:35, Eric Blake ha scritto:
> block-migration.c uses !bdrv_is_allocated as a condition for a
> while loop; should that check for errors?

Not needed, in case of an error it will exit the loop and read the
sector.  This will probably cause another error that will be
reported---or if it succeeds, it's safe and may in the worst case
cause extra data to be migrated.

> block/vvfat.c contains an if (bdrv_is_allocated(...)); should that 
> handle errors?

No idea, vvfat is black magic. :(

Paolo

> If you can justify that those don't need changes, then I'm okay
> with:
> 
> Reviewed-by: Eric Blake <address@hidden>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSIEdEAAoJEBvWZb6bTYbyTtYQAIb2BUcJMjAU/ULufDA4rDNt
SRh0NhXIdAM+G34PhE9WbhJ06DUtaa6T8nnHWnx70w0PR8XIDE1BUZDdC1AZv6st
ebsNSFB4KIVSH0zKgeMD20qLnJcVpVPlxNHmbCs9odnLUgMGF2+2n64j/zRvc/RW
H0l4DWZFknwapqcfSV4w8Idh4t/ma6HG9hkYNhNVam9eEaOWPFLGJosTQ5HeIvhU
n8kZrECzv5GzXmf301E+QUmti3igfAevwc5rNAbj1pzPzbZJD58WLWXZVsrVV8VR
QC8ABSTpMR+O3mjMexX/Bymg9jSZYAD5q47wXFnZSh0XOhzAiGuokLts2hkTYH2H
xxbRhFiNgxp7qjIHDMAvUqilwDx01JKzjtosKlcAFRfidklOMBdOCLz3Q6vN4JmH
DOb5nb9EjjORoAiveA3EqOOHUA9QNzsfkKr6ql94sJQZP4YUHg7dJwamXzqbxVys
Szu1wVhe2LB0BYjx+uKuxREaU+F++c36TKM7ilIlXje4TucbhGzunEy2O1Wynz9i
39zZe4fhSXoNpQHu5qjzP20y3l/wbMXXdYnq/x+ey9h4Gxcpd/IBecUtUQffd/SQ
acrtoWZUaCeWeSM0PXPt3oJr2pqFQnzhIxE34mP82mpdsrjEJXYhnVSwsVf/CecQ
nSiNzu/gWraEutp/6vcE
=tb+T
-----END PGP SIGNATURE-----