[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] aio / timers: use g_usleep() not sleep()
|
From: |
Alex Bligh |
|
Subject: |
Re: [Qemu-devel] [PATCH] aio / timers: use g_usleep() not sleep() |
|
Date: |
Thu, 29 Aug 2013 23:33:50 +0100 |
On 29 Aug 2013, at 19:38, Stefan Weil wrote:
>>
>> - sleep(1);
>> + g_usleep(1*G_USEC_PER_SEC);
>
> Although checkpatch.pl does not complain, I'd prefer a blank before
> and after operators like "*".
>
> Here a simple g_usleep(G_USEC_PER_SEC) would be even better.
Prefer 1 as it's then obvious its a conversion and 1 second.
But I've fixed the blank and sent that as v2. I suspect checkpatch
is confused about * meaning a pointer dereference.
--
Alex Bligh