Re: [Qemu-devel] [PATCH v1] gluster: Abort on AIO completion failure

[Kevin Wolf]

Am 29.08.2013 um 09:35 hat Stefan Hajnoczi geschrieben:
> On Tue, Aug 27, 2013 at 01:45:41PM +0530, Bharata B Rao wrote:
> > Currently if gluster AIO callback thread fails to notify the QEMU thread 
> > about
> > AIO completion, we try graceful recovery by marking the disk drive as
> > inaccessible. This error recovery code is race-prone as found by Asias and
> > Stefan. However as found out by Paolo, this kind of error is impossible and
> > hence simplify the code that handles this error recovery.
> > 
> > Signed-off-by: Bharata B Rao <address@hidden>
> > ---
> > Changes in v1: Print errno information.
> > 
> > 
> >  block/gluster.c | 15 ++-------------
> >  1 file changed, 2 insertions(+), 13 deletions(-)
> 
> Reviewed-by: Stefan Hajnoczi <address@hidden>

Thanks, applied to the block branch. (Wouldn't have hurt though to
mention why this kind of error is impossible and what the race is.)

Kevin