[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom-cpu/arm-devs] hw/cpu/a15mpcore: Use qemu_get
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH qom-cpu/arm-devs] hw/cpu/a15mpcore: Use qemu_get_cpu() for generic timers |
|
Date: |
Wed, 28 Aug 2013 17:11:06 +0100 |
On 28 August 2013 16:35, Andreas Färber <address@hidden> wrote:
> For the MPCore series in my ARM/Tegra tree you wanted an assert for
> object_initialize(). I am waiting for you to comment on my more
> invasive/complete series (last part being optional), which would then
> with any suggested changes go through my QOM tree before I add more uses
> of object_initialize() that would need to be converted.
Ah, OK. I'm moving house this week so probably won't get to
detailed review til next week, but I think in general it looked OK.
Having to pass "&X, sizeof(X)" in the most common case is
a little unfortunate but I think the bus related code and so on
convinced me it was necessary.
-- PMM