[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 b
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error |
|
Date: |
Tue, 27 Aug 2013 12:48:31 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 08/27/2013 09:48 AM, Yongbok Kim wrote:
> #if 0
> - qemu_log(TARGET_FMT_lx " %d %d => " TARGET_FMT_lx " %d (%d)\n",
> + qemu_log(TARGET_FMT_lx " %d %d => %" HWADDR_PRIx " %d (%d)\n",
> address, rw, access_type, *physical, *prot, ret);
> #endif
While by itself correct, consider converting this to the trace infrastructure
(with uint64_t instead of hwaddr).
If it's not worth a trace, it's probably not worth keeping at all.
r~