[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return addr
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument |
Date: |
Tue, 27 Aug 2013 00:26:00 +0100 |
On 26 August 2013 22:00, Richard Henderson <address@hidden> wrote:
> Allow the code that tcg generates to be less obtuse, passing in
> the return address directly instead of computing it in the helper.
> +uint8_t helper_ret_ldb_mmu(CPUArchState *env, target_ulong addr,
> + int mmu_idx, uintptr_t retaddr);
> uint8_t helper_ldb_mmu(CPUArchState *env, target_ulong addr, int mmu_idx);
I thought the reason we did it this way round was to avoid having
so many arguments to helpers that we overflowed registers and
into the stack on some calling conventions? Or does this not make
much difference in practice?
thanks
-- PMM
- [Qemu-devel] [PULL 2/7] tcg-i386: Add and use tcg_out64, (continued)
- [Qemu-devel] [PULL 2/7] tcg-i386: Add and use tcg_out64, Richard Henderson, 2013/08/26
- [Qemu-devel] [PULL 3/7] tcg-i386: Try pc-relative lea for constant formation, Richard Henderson, 2013/08/26
- [Qemu-devel] [PULL 4/7] tcg-i386: Tidy qemu_ld/st slow path, Richard Henderson, 2013/08/26
- [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Richard Henderson, 2013/08/26
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Paolo Bonzini, 2013/08/26
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Richard Henderson, 2013/08/26
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Aurelien Jarno, 2013/08/27
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Richard Henderson, 2013/08/27
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Aurelien Jarno, 2013/08/27
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Richard Henderson, 2013/08/27
Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument,
Peter Maydell <=
[Qemu-devel] [PULL 6/7] tcg: Tidy softmmu_template.h, Richard Henderson, 2013/08/26
[Qemu-devel] [PULL 7/7] tcg-i386: Use new return-argument ld/st helpers, Richard Henderson, 2013/08/26
Re: [Qemu-devel] [PULL 0/7] Improve tcg ldst optimization, Aurelien Jarno, 2013/08/27