[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/7] tcg: Tidy generated code for tcg_outN
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 1/7] tcg: Tidy generated code for tcg_outN |
Date: |
Mon, 26 Aug 2013 14:00:06 -0700 |
Aliasing was forcing s->code_ptr to be re-read after the store.
Keep the pointer in a local variable to help the compiler.
Signed-off-by: Richard Henderson <address@hidden>
---
tcg/tcg.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index dac8224..42c95af 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -121,14 +121,16 @@ static inline void tcg_out8(TCGContext *s, uint8_t v)
static inline void tcg_out16(TCGContext *s, uint16_t v)
{
- *(uint16_t *)s->code_ptr = v;
- s->code_ptr += 2;
+ uint8_t *p = s->code_ptr;
+ *(uint16_t *)p = v;
+ s->code_ptr = p + 2;
}
static inline void tcg_out32(TCGContext *s, uint32_t v)
{
- *(uint32_t *)s->code_ptr = v;
- s->code_ptr += 4;
+ uint8_t *p = s->code_ptr;
+ *(uint32_t *)p = v;
+ s->code_ptr = p + 4;
}
/* label relocation processing */
--
1.8.1.4
- [Qemu-devel] [PULL 0/7] Improve tcg ldst optimization, Richard Henderson, 2013/08/26
- [Qemu-devel] [PULL 1/7] tcg: Tidy generated code for tcg_outN,
Richard Henderson <=
- [Qemu-devel] [PULL 2/7] tcg-i386: Add and use tcg_out64, Richard Henderson, 2013/08/26
- [Qemu-devel] [PULL 3/7] tcg-i386: Try pc-relative lea for constant formation, Richard Henderson, 2013/08/26
- [Qemu-devel] [PULL 4/7] tcg-i386: Tidy qemu_ld/st slow path, Richard Henderson, 2013/08/26
- [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Richard Henderson, 2013/08/26
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Paolo Bonzini, 2013/08/26
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Richard Henderson, 2013/08/26
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Aurelien Jarno, 2013/08/27
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Richard Henderson, 2013/08/27
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Aurelien Jarno, 2013/08/27
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Richard Henderson, 2013/08/27