[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH -V3 1/4] target-ppc: Update slb array with corre
|
From: |
Aneesh Kumar K.V |
|
Subject: |
Re: [Qemu-devel] [PATCH -V3 1/4] target-ppc: Update slb array with correct index values. |
|
Date: |
Mon, 26 Aug 2013 17:46:25 +0530 |
|
User-agent: |
Notmuch/0.15.2+167~g5306b2b (http://notmuchmail.org) Emacs/24.3.50.1 (x86_64-unknown-linux-gnu) |
Alexander Graf <address@hidden> writes:
> On 26.08.2013, at 08:46, Aneesh Kumar K.V wrote:
>
>> Alexander Graf <address@hidden> writes:
>>
....
>>>
>>>> + */
>>>> + memset(env->slb, 0, 64 * sizeof(ppc_slb_t));
>>>
>>> Can't we use ARRAY_SIZE here and below?
>>
>> I was thinking we want to be explicit there saying we are zeroing out all
>> the 64 entries. I could do sizeof(env->slb).
>
> Yup, that works too. In the loop below s/64/ARRAY_SIZE(env->slb)/ should work
> too I think.
>
Updated with the above change.
-aneesh