[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scsi: Fix scsi_bus_legacy_add_drive() scsi-gene
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH] scsi: Fix scsi_bus_legacy_add_drive() scsi-generic with serial |
|
Date: |
Fri, 23 Aug 2013 18:08:48 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 |
Am 23.08.2013 18:01, schrieb address@hidden:
> From: Markus Armbruster <address@hidden>
>
> scsi_bus_legacy_add_drive() creates either a scsi-disk or a
> scsi-generic device. It sets property "serial" to argument serial
> unless null. Crashes with scsi-generic, because it doesn't have such
> the property.
>
> Only usb_msd_initfn_storage() passes non-null serial. Reproducer:
>
> $ qemu-system-x86_64 -nodefaults -display none -S -usb \
> -drive if=none,file=/dev/sg1,id=usb-drv0 \
> -device usb-storage,id=usb-msd0,drive=usb-drv0,serial=123
> qemu-system-x86_64: -device
> usb-storage,id=usb-msd0,drive=usb-drv0,serial=123: Property '.serial' not
> found
> Aborted (core dumped)
>
> Fix by handling exactly like "removable": set the property only when
> it exists.
>
> Cc: address@hidden
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> hw/scsi/scsi-bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Andreas Färber <address@hidden>
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg