[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] virtio: Remove unnecessary OBJECT casts
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] virtio: Remove unnecessary OBJECT casts |
Date: |
Fri, 23 Aug 2013 16:19:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 |
Am 23.08.2013 15:38, schrieb Peter Maydell:
> There's no need to cast the first argument of object_initialize
> to Object, and it would defeat the ability to check that the
> pointer being passed is to a type large enough for the object.
> Remove these unnecessary casts.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> hw/s390x/s390-virtio-bus.c | 12 ++++++------
> hw/s390x/virtio-ccw.c | 14 +++++++-------
> hw/virtio/virtio-pci.c | 16 ++++++++--------
> 3 files changed, 21 insertions(+), 21 deletions(-)
Reviewed-by: Andreas Färber <address@hidden>
Depending on how we proceed we may want to tweak the commit message.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg