[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: Fix debug print type
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH] migration: Fix debug print type |
Date: |
Fri, 23 Aug 2013 09:11:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 |
See my comment below.
Am 23.08.2013 09:06, schrieb Christoffer Dall:
> The printf args are uint64_t and with -Werr QEMU doesn't compile with
> migration debugging turned on unless this is fixed. Fix it.
>
> Signed-off-by: Christoffer Dall <address@hidden>
> ---
> migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration.c b/migration.c
> index 1402fa7..0d8706f 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -566,7 +566,7 @@ static void *migration_thread(void *opaque)
> if (!qemu_file_rate_limit(s->file)) {
> DPRINTF("iterate\n");
> pending_size = qemu_savevm_state_pending(s->file, max_size);
> - DPRINTF("pending size %lu max %lu\n", pending_size, max_size);
> + DPRINTF("pending size %llu max %llu\n", pending_size, max_size);
Please use PRIu64 for uint64_t.
> if (pending_size && pending_size >= max_size) {
> qemu_savevm_state_iterate(s->file);
> } else {