[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH V9 03/12] NUMA: check if the total numa memory size
From: |
Wanlong Gao |
Subject: |
[Qemu-devel] [PATCH V9 03/12] NUMA: check if the total numa memory size is equal to ram_size |
Date: |
Fri, 23 Aug 2013 12:09:54 +0800 |
If the total number of the assigned numa nodes memory is not
equal to the assigned ram size, it will write the wrong data
to ACPI talb, then the guest will ignore the wrong ACPI table
and recognize all memory to one node. It's buggy, we should
check it to ensure that we write the right data to ACPI table.
Signed-off-by: Wanlong Gao <address@hidden>
---
vl.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/vl.c b/vl.c
index 8829344..46d1d55 100644
--- a/vl.c
+++ b/vl.c
@@ -4172,6 +4172,16 @@ int main(int argc, char **argv, char **envp)
node_mem[i] = ram_size - usedmem;
}
+ uint64_t numa_total = 0;
+ for (i = 0; i < nb_numa_nodes; i++) {
+ numa_total += node_mem[i];
+ }
+ if (numa_total != ram_size) {
+ fprintf(stderr, "qemu: numa nodes total memory size "
+ "should equal to ram_size\n");
+ exit(1);
+ }
+
for (i = 0; i < nb_numa_nodes; i++) {
if (!bitmap_empty(node_cpumask[i], MAX_CPUMASK_BITS)) {
break;
--
1.8.4.rc4
- [Qemu-devel] [PATCH V9 00/12] Add support for binding guest numa nodes to host numa nodes, Wanlong Gao, 2013/08/23
- [Qemu-devel] [PATCH V9 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions, Wanlong Gao, 2013/08/23
- [Qemu-devel] [PATCH V9 04/12] NUMA: move numa related code to numa.c, Wanlong Gao, 2013/08/23
- [Qemu-devel] [PATCH V9 05/12] NUMA: Add numa_info structure to contain numa nodes info, Wanlong Gao, 2013/08/23
- [Qemu-devel] [PATCH V9 06/12] NUMA: Add Linux libnuma detection, Wanlong Gao, 2013/08/23
- [Qemu-devel] [PATCH V9 08/12] NUMA: set guest numa nodes memory policy, Wanlong Gao, 2013/08/23
- [Qemu-devel] [PATCH V9 07/12] NUMA: parse guest numa nodes memory policy, Wanlong Gao, 2013/08/23
- [Qemu-devel] [PATCH V9 10/12] NUMA: add hmp command set-mem-policy, Wanlong Gao, 2013/08/23
- [Qemu-devel] [PATCH V9 03/12] NUMA: check if the total numa memory size is equal to ram_size,
Wanlong Gao <=
- [Qemu-devel] [PATCH V9 11/12] NUMA: add qmp command query-numa, Wanlong Gao, 2013/08/23
- [Qemu-devel] [PATCH V9 12/12] NUMA: convert hmp command info_numa to use qmp command query_numa, Wanlong Gao, 2013/08/23
- [Qemu-devel] [PATCH V9 02/12] NUMA: split -numa option, Wanlong Gao, 2013/08/23
- [Qemu-devel] [PATCH V9 09/12] NUMA: add qmp command set-mem-policy to set memory policy for NUMA node, Wanlong Gao, 2013/08/23