Re: [Qemu-devel] [PATCH v5 0/8] Implement reference count for BlockDriverState [resend]

[Wenchao Xia]

于 2013-8-22 19:38, Stefan Hajnoczi 写道:
> On Fri, Aug 09, 2013 at 06:01:53PM +0800, Fam Zheng wrote:
> > [resend to the correct list]
> >
> > BlockDriverState lifecycle management is needed by future features such as
> > image fleecing and blockdev-add. This series adds reference count to
> > BlockDriverState.
> >
> > The first two patches clean up two odd BlockDriverState use cases, so all code
> > uses bdrv_new() to create BlockDriverState instance.
> >
> > Then implemented bdrv_ref() and bdrv_unref() to operate on refcnt: Initially,
> > refcnt is 1, which means bdrv_unref is effectively a bdrv_delete() here. So
> > patch 04 has a search and replace to convert bdrv_delete to bdrv_unref, before
> > bdrv_ref is used anywhere. 05~08 patches calls bdrv_ref for device attach,
> > block-migration and nbd.
> >
> > The rule is: Either bdrv_ref() or bdrv_new() must have a matching
> > bdrv_unref() call, and the last matching bdrv_unref deletes the bs.
> >
> > v4:
> >      08: Added, let block job use BDS reference.
> >      02: Fix leak of bs.opaque
> >
> > v3:
> >      03: Removed unnecessary bdrv_close() call.
> >
> > v2:
> >      05: Removed: "block: use BlockDriverState refcnt for device attach/detach"
> >      07: Fix xen_disk blk_disconnect() as it depended on device attach refcnt.
>
> Sorry, can't merge this because it breaks qemu-iotests 041 and 055:
>
>    $ ./check -qcow2 055 041
>
> Please always run qemu-iotests before submitting patches.
>
> Stefan
Hi,
  What is the correct steps to run full qemu-iotests?
I modified qemu-iotests-quick.sh as:

#!/bin/sh

# We don't know which of the system emulator binaries there is (or if 
there is
# any at all), so the 'quick' group doesn't contain any tests that require
# running qemu proper. Assign a fake binary name so that qemu-iotests 
doesn't
# complain about the missing binary.
export QEMU_PROG="$(pwd)/x86_64-softmmu/qemu-system-x86_64"

export QEMU_IMG_PROG="$(pwd)/qemu-img"
export QEMU_IO_PROG="$(pwd)/qemu-io"
export QEMU_NBD_PROG="$(pwd)/qemu-nbd"

cd $SRC_PATH/tests/qemu-iotests

ret=0
./check -T -nocache -qcow2 || ret=1

exit $ret

  Then make check-block, 026 038 fail, 038 sometimes fail.
The code from is upstream, host is RH6.3 @ x86_64. Do I missed some
steps?
--
Best Regards

Wenchao Xia