[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH ] qemu-help: add category headlines
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH ] qemu-help: add category headlines |
Date: |
Thu, 22 Aug 2013 09:34:05 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 08/22/2013 08:13 AM, Markus Armbruster wrote:
>>> +++ b/qdev-monitor.c
>>> @@ -156,6 +156,8 @@ static void qdev_print_category_devices(DeviceCategory
>>> category)
>>> DeviceClass *dc;
>>> GSList *list, *curr;
>>>
>>> + error_printf("%s devices:\n", qdev_category_get_name(category));
>>
>> Why is that an error? Shouldn't it go to stdout?
>
> Output of -device help has always gone to stderr, and that has always
> annoyed me. Just not enough to fix it.
Back when libvirt scraped -help output, changing it to use stdout would
be an incompatible change. But now that libvirt uses QMP, I would also
welcome a change to use stdout (but also fall in the category of "not
enough of a bother for ME to fix it).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH ] qemu-help: add category headlines, Marcel Apfelbaum, 2013/08/28